[FIX #540] ignore connections to inner modules of containers

src/core/kernel/combiner/WModuleProjectFileCombiner.cpp

@@ -446,8 +446,11 @@ void WModuleProjectFileCombiner::save( std::ostream& output )   // NOLINT
             {
                 // as the module is a weak_ptr -> lock and get access to it
                 std::shared_ptr< WModule > theOtherModule = ( *iciter )->m_module.lock();
-                output << "CONNECTION:(" << moduleToIDMap[ ( *iter ) ] << "," << ( *citer )->getName() << ")->(" <<
-                                            moduleToIDMap[ theOtherModule ] << "," << ( *iciter )->getName() << ")" << std::endl;
+                if( moduleToIDMap.find( theOtherModule ) != moduleToIDMap.end() )
+                {
+                    output << "CONNECTION:(" << moduleToIDMap[ ( *iter ) ] << "," << ( *citer )->getName() << ")->(" <<
+                                                moduleToIDMap[ theOtherModule ] << "," << ( *iciter )->getName() << ")" << std::endl;
+                }
             }
             lock.unlock();
         }

[Alexander Wiebel]

Please add a comment to explain this line to fellow developers

[Alexander Wiebel]

Does this commit exclude only internal connection or also connection to itself? ... e.g. if a module has multiple inputs and one output, it could be desired to have a loop connection

[Robin Eschbach]

It excludes connections to modules that are not in the normal module list. So it should only exclude internal connections.

[Alexander Wiebel]

Thx